Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to follow up contribution guidelines work #3846

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented Jan 23, 2024

@theletterf
Copy link
Member Author

@svrnm @chalin Did the mirrored documentation guidelines change / were removed? I don't think we've them in prod: 7c1dcce

Can't trace when/where they were removed. I take they no longer apply, as we use a more generic language in our new contribution guide. As they were still linked from contribution-guidelines I was wondering.

@theletterf theletterf requested a review from chalin January 23, 2024 09:58
@theletterf
Copy link
Member Author

Also, do we want to promote the newly created https://github.com/open-telemetry/opentelemetry.io/discussions board? I'd wait a bit before doing so, perhaps...

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I'd like to also get @chalin's approval

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested tweak, otherwise LGTM overall :)

.htmltest.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! We need to add an alias for the page that was removed.

@chalin
Copy link
Contributor

chalin commented Jan 29, 2024

@svrnm @chalin Did the mirrored documentation guidelines change / were removed? I don't think we've them in prod: 7c1dcce

Those guidelines no longer apply.

For context, see:

@chalin
Copy link
Contributor

chalin commented Jan 29, 2024

Also, do we want to promote the newly created https://github.com/open-telemetry/opentelemetry.io/discussions board? I'd wait a bit before doing so, perhaps...

I'm ok with waiting a bit too.

@chalin chalin mentioned this pull request Jan 29, 2024
@theletterf theletterf requested a review from chalin January 30, 2024 09:47
@theletterf
Copy link
Member Author

@chalin
Copy link
Contributor

chalin commented Jan 30, 2024

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin chalin force-pushed the theletterf-follow-up-3767 branch from e83dd07 to 308dbe3 Compare January 30, 2024 10:07
@chalin chalin force-pushed the theletterf-follow-up-3767 branch from 308dbe3 to 986d476 Compare January 30, 2024 10:57
@chalin chalin merged commit d99f15e into main Jan 30, 2024
16 checks passed
@chalin chalin deleted the theletterf-follow-up-3767 branch January 30, 2024 11:02
jaydeluca pushed a commit to jaydeluca/opentelemetry.io that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Followup updates to Contributing info Contribution guidelines needs rework or should be dropped
3 participants